[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9555] Add MDNS probing
|
From: |
Erik Ekman |
|
Subject: |
[lwip-devel] [patch #9555] Add MDNS probing |
|
Date: |
Sun, 28 Jan 2018 15:36:23 -0500 (EST) |
|
User-agent: |
Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 |
Follow-up Comment #2, patch #9555 (project lwip):
Thanks, this looks very promising!
I don't think the nullcheck works in mdns_resp_restart() since NETIF_TO_HOST
already deferences it:
+ struct mdns_host* mdns = NETIF_TO_HOST(netif);
+ LWIP_ASSERT_CORE_LOCKED();
+ LWIP_ERROR("mdns_resp_start: netif != NULL", (netif != NULL), return);
Not sure if it makes sense to include the _services._dns-sd._udp.local ->
service type PTR and also the service type to service name PTR among the probe
authorative answers. Does the RFC give guidance on this? Or other
implementations?
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9555>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/