[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnic
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp |
Date: |
Mon, 29 Jan 2018 01:35:24 -0500 (EST) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 |
Follow-up Comment #4, patch #9525 (project lwip):
I really don't know if this fits. Anyway, a few generic comments:
- don't add third party code without a license that fits. I can't even see a
license at all for base64 and sha1
- when using sha1, use it like ppp does (polarssl/mbedtls)
- base64 encoding is used in smtp, too. We need to combine this instead of
adding it a second time. Again, watch out for licensing issues here!
As to the actual web socket implementation: I won't add it like this to
httpd.c. That file is too big and unreadable like it is now, adding yet more
code would be bad. You might try to add a httpd_websockets.c file and come off
with minimal changes to integrate this into httpd.c
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9525>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Sakari Kapanen, 2018/01/28
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Dirk Ziegelmeier, 2018/01/29
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp,
Simon Goldschmidt <=
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Sakari Kapanen, 2018/01/29
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Simon Goldschmidt, 2018/01/29
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Sakari Kapanen, 2018/01/29
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Simon Goldschmidt, 2018/01/29
- [lwip-devel] [patch #9525] httpd: add Websocket support, fix lwip_strnicmp, Sakari Kapanen, 2018/01/29