[lwip-devel] Important clang warning

[Gisle Vanem]

A pretty important warning from clang-cl:

src/contrib/ports/win32/sys_arch.c(457,28):  warning: cast between incompatible 
calling conventions
'cdecl' and 'stdcall'; calls through this pointer may abort at runtime 
[-Wcast-calling-convention]
    h = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)sys_thread_function, new_thread, 0, 
&(new_thread->id));
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/contrib/ports/win32/sys_arch.c(425,1):  note: consider defining 
'sys_thread_function'
with the 'stdcall' calling convention sys_thread_function(void* arg)

Mixing stdcall with cdecl can be dangerous; maybe not in this case though?

--
--gv