|
From: | Dirk Ziegelmeier |
Subject: | [lwip-devel] [task #15072] SNMP support for notifications and informs (v2c) |
Date: | Wed, 24 Oct 2018 04:11:49 -0400 (EDT) |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0 |
Follow-up Comment #3, task #15072 (project lwip): Please check you patch again and read/check all the issues I reported. Most of them are not fixed! - usage of BUILD_EXEC() in functions returning void - unused stuff in err.h - instantiation of local variables in code (struct snmp_obj_id snmp_trap_oid = { 0 }) in snmp_send_trap_or_notification_or_inform_generic() I recommend you to crank up your warning settings (gcc: -Wall, -pedantic) and use warnings->errors when compiling (gcc: -Werror) it will seriously improve code quality! _______________________________________________________ Reply to this item at: <https://savannah.nongnu.org/task/?15072> _______________________________________________ Message sent via Savannah https://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |