Re: [lwip-users] RE:Re: Checksum problem with lwip_chksum()

[Jim Gibbons]

I see the problem.  There are currently 8 ports in contrib, and many others that haven't ever been put there.  Each would have to be changed.  Changing the 8 that are in contrib wouldn't be too difficult, but no single contributor would be able to retest them.  This is a bit of a mess.

Perhaps it could be made a little safer and easier by introducing a macro to be used in place of the calls to lwip_chksum that are now made.  The changes would be as follows:

1) Make sure that inet.c includes sys_arch.h, either directly or indirectly.

2) Change all references to lwip_chksum to LWIP_CHKSUM.

3) Conditionally define LWIP_CHKSUM in inet.c.

#ifndef LWIP_CHKSUM
/* comments to explain the intended use */
#define LWIP_CHKSUM lwip_chksum /* perhaps include parameters... */
#endif

Anyone who needed to change it could do so by adding a function prototype and a definition of LWIP_CHKSUM to sys_arch.h.

A possible objection to this would be that it isn't sufficiently clear to the developer of a new port that this is an issue to be examined.  I don't really see how to resolve that without biting the bullet and changing a lot of existing ports.  Which would take us right back to the retesting problem...


K.J. Mansley wrote:

On Fri, 2004-09-03 at 23:18, Jim Gibbons wrote:
  

Perhaps it might be wise to move lwip_chksum into sys_arch.c?  
    

I also think this is a good idea.  It's been suggested before, but I
can't remember if there were any objections that led to it not
happening, or if it just didn't happen because nobody did it.

Any volunteers this time?

Kieran



_______________________________________________
lwip-users mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/lwip-users
  

--

Jim Gibbons	address@hidden
Gibbons and Associates, Inc.	TEL: (408) 984-1441
900 Lafayette, Suite 704, Santa Clara, CA	FAX: (408) 247-6395