lwip-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [lwip-users] [PATCH] fix warning for gcc and possible unaligned acce


From: Leon Woestenberg
Subject: RE: [lwip-users] [PATCH] fix warning for gcc and possible unaligned access
Date: Sun, 30 Apr 2006 23:36:16 +0200

Curt, Timmy,

On Tue, 2006-04-25 at 16:00 -0700, Curt McDowell wrote:
> Timmy Brolin wrote:
> > But replacing ip_addr2 with ip_addr will break things on all 
> > compilers that do not support packed structs. Possibly others as well.
> 
Timmy, thanks for crawling back through the mailing list archives and
explaining why we did this back then. My memory had lost me there (uh,
or is the other way around? :-)

> Ah; if lwip was meant to compile without packed structs, that explains a lot.
> It would have saved a lot of hassle if ip_addr2 had a comment next to it, and
> was not itself packed, or if the comments in etharp.c mentioned that...
> 
Sure, we should have done that back then - it would ourselves have saved
half of this discussion. Can someone commit a note now?

Finding these workarounds (and a lot of others in lwIP, such as the
#include's around packed structs) has cost half of the development time
of lwIP. :-/

Regards,

Leon.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]