| [lwip-users]
[PATCH 4/7] lwip: fix warning 'code has no effect' where mem_realloc was
used |
To be honest, since we could/should(?) use
mem_realloc like this : "pr = mem_realloc(p,x)", your change doesn't
work.
I made this change becaure the rval was never used and gave a warning with my compiler.
Yes - if someone does make a change like you describe they will get a compile error, but I would suggest that in this case mem_realloc shound no-longer be a stub? Personally I think a compile error is a good thing in this case.
About the comment, it's "trivial", but a comment
never kill everyone.
I don't understand what you mean by this, can you please clarify? The patch added a comment to the code to explain why realloc() was a stub and the commit documented the issue it fixed.
Andrew