Re: [lwip-users] PPP build inconsistency

[Marko Panger]

1) As for the ppp.c file at line 507 it could be conditional compiled by the definition PPPOE_SUPPORT, resulting in

#if PPPOE_SUPPORT
        pc->ethif= NULL;
#endif

2) As for the line 1340 it could be also conditional compiled by LWIP_DHCP, but I really don't know what this line of code does.
(pc->netif.dhcp = (struct dhcp *) &pc->addrs;) Further examination of the entire lwip code shows that this member is only referenced in two files. The first reference is in the dhcp.c file, which is not needed if LWIP_DHCP is 0. The second is the netif.c file where is conditionally compiled by the same define.


marko

Kieran Mansley wrote:

On Wed, 2007-10-10 at 17:01 +0200, Marko Panger wrote:
  

Hi all,

Im' trying to build the lwip stack with PPPOS_SUPPORT enabled and 
PPPOE_SUPPORT disabled (gprs connection).

When building the latest cvs snapshot code there is a build error on 
line 507 of the ppp.c file. The code is trying to reference a member of 
the PPPControl_s structure (pc->ethif= NULL;). On line 141 of the same 
file, this member is not compiled due to the PPPOE_SUPPORT definition 
being 0 in my case.

Again, the code is trying to reference the dhcp member of the netif 
structure on line 1340 of the ppp.c file, although my configuration is 
LWIP_DHCP 0. Btw. this line is commented with "/* ugly workaround for 
storing a reference to the ppp related info*/". Being ugly what should I 
take care of ?
    

Those would appear to be just cases where the code hasn't been compiled
with the various options turned on an off - this is one of the reasons
why so many compile time options can be troublesome, but they do help to
keep the compiled code small.

The solution really needs someone who understands the PPP code though,
which I'm not, and they're a bit thin on the ground at the moment.  Any
volunteers to help fix this?

Kieran 




_______________________________________________
lwip-users mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/lwip-users


__________ NOD32 2584 (20071010) Information __________

This message was checked by NOD32 antivirus system.
http://www.eset.com