[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev [PATCH][dev21] Remove cut-n-paste code in www_user_search
From: |
Philip Webb |
Subject: |
Re: lynx-dev [PATCH][dev21] Remove cut-n-paste code in www_user_search |
Date: |
Thu, 1 Apr 1999 19:44:35 -0500 (EST) |
990401 John Bley wrote:
> * Spawn a new function, www_user_search_internals, to begin cancelling
> the effects of cut-n-paste coding in www_user_search. The body of
> www_user_search_internals used to be duplicated at two points in
> www_user_search. See comment in GridText.c for more details. (John Bley)
> Doing this actually cuts the size of the binary by a KB without modifying
> behaviour at all (unless I screwed up somewhere). It's kind of a
> toss-up as to whether it actually makes the code "cleaner" though...
even my small perusal of Lynx source revealed a couple of places
where one piece of code had apparently been copied to another place aswas;
duplication like that surely makes a program more difficult to maintain.
this kind of thing probably reflects the rapid expansion of Lynx
during early development days, which no-one has ever tidied up.
we should always remember how hard the early developers worked at it.
--
========================,,============================================
SUPPORT ___________//___, Philip Webb : address@hidden
ELECTRIC /] [] [] [] [] []| Centre for Urban & Community Studies
TRANSIT `-O----------O---' University of Toronto