Re: lynx-dev [PATCH 2.8.3.dev6] various fixes

[Klaus Weide]

On Sun, 15 Aug 1999, Vlad Harchev wrote:

>  This is the patch that fixes yet another bug in justification code (anchor
> position recalculation) and fixes the GridText.c:*TrimHightext (it was not
                                                                  ----------
> designed to support LY_SOFT_NEWLINES) - this corrects rendering of links on
  ------------------------------------
> wrapped lines in psrc mode.

A comment on the underlined sentence:  Yes, that's basically correct.
The -prettysrc mode breaks several invariants (things that, so far, were
always true):

 - There are no anchors in source mode.
 - LYK_SOFT_NEWLINE only occurs in source mode.
 - LYK_SOFT_NEWLINE never occurs in a document that has any anchors
   (a direct consequence of the previous two).

I find it likely that breaking these assumptions has more consequences
than have so far been found.  It's not surprising that changes in
anchor handling are needed; what is surprising is that the whole thing
doesn't blow up in your face without more changes. :)

These remarks are not based on any examination of how the new
prettysrc and justify stuff works, just on my understanding of how
things used to be.

Maybe there should be a sub-mode of "prettysrc" in which anchors are
not generated at all in the source view.  This would avoid problems of
this kind, and also the 'inserted [nn] makes source invalid' problem.
OTOH I don't particularly like an infltion of yet more options for
prettysrc.

   Klaus