Re: lynx-dev [PATCH 2.8.3.dev10] Scrollbar doubleclick support

[Leonid Pauzner]

20-Oct-99 23:29 Ilya Zakharevich wrote:
>> Are you sure with that?

>> #ifdefing with DISP_PARTIAL could be not enough:
>> there is `display_partial' flag which may be OFF.
>> It is ON when the loading is in progress
>> and 'partial mode' was not disabled by user via lynx.cfg
>> or commandline -partial taggle.

> Why?  All the code is doing is setting Newline.  What has
> "display_partial" do with this?  I do not care if double-click is
> ignored in non-partial mode - your suggestion is doing the same.

That's up to you (I never use mouse with lynx),
I was just curious that you #ifdef'ed with DISP_PARTIAL
when it is not something specific to partial display mode.

Either
        {
        ...
        }
or

#ifdef DISP_PARTIAL
        if (partial_display)
        {
        ...
        }

in your case and no in between

Oh, perhaps, you feel not comfortable with Newline
being non public without DISP_PARTIAL ?
If this is the case we could change
its declaration in LYGlobalDefs.h/LYMainLoop.c
but only when you absolutely sure you need it.


> Ilya