[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: enhancement to builtin
From: |
Eric Blake |
Subject: |
Re: RFC: enhancement to builtin |
Date: |
Mon, 30 Oct 2006 19:22:02 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Thunderbird/1.5.0.7 Mnenhy/0.7.4.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 10/27/2006 11:02 AM:
>> Here's a proposal for enhancing the 'builtin' macro to make it possible to
>> recover a builtin macro, even if all references to it have been undefined.
>> Hopefully, the proposed documentation in the patch will give some more
>> details on how this could be useful. Any objections to installing this?
>
> I interpreted silence as consent, and installed this:
Except that commit had some extra, unnecessary code.
2006-10-30 Eric Blake <address@hidden>
* m4/m4private.h (m4_get_symbol_value_module): Delete accidental
checkin.
* m4/symtab.c (m4_get_symbol_value_module): Likewise.
- --
Life is short - so eat dessert first!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFRrNK84KuGfSFAYARAuuUAKC6eQq4kp7UilBdvdRM8EtTkNjsygCgyLcU
+lJo/dtkch72+eWJGsQTtuw=
=S6DB
-----END PGP SIGNATURE-----
Index: m4/m4private.h
===================================================================
RCS file: /sources/m4/m4/m4/m4private.h,v
retrieving revision 1.69
diff -u -p -r1.69 m4private.h
--- m4/m4private.h 27 Oct 2006 17:03:51 -0000 1.69
+++ m4/m4private.h 31 Oct 2006 02:21:13 -0000
@@ -221,7 +221,6 @@ struct m4_symbol_value {
# define m4_get_symbol_value_builtin(V) ((V)->u.builtin)
# define m4_get_symbol_value_placeholder(V) \
((V)->u.text)
-# define m4_get_symbol_value_module(V) (VALUE_HANDLE (V))
# define m4_symbol_value_groks_macro(V) (BIT_TEST ((V)->flags,
\
VALUE_MACRO_ARGS_BIT))
Index: m4/symtab.c
===================================================================
RCS file: /sources/m4/m4/m4/symtab.c,v
retrieving revision 1.68
diff -u -p -r1.68 symtab.c
--- m4/symtab.c 31 Oct 2006 02:05:37 -0000 1.68
+++ m4/symtab.c 31 Oct 2006 02:21:13 -0000
@@ -658,14 +658,6 @@ m4_get_symbol_value_placeholder (m4_symb
return value->u.text;
}
-#undef m4_get_symbol_value_module
-lt_dlhandle
-m4_get_symbol_value_module (m4_symbol_value *value)
-{
- assert (value);
- return VALUE_HANDLE (value);
-}
-
#undef m4_set_symbol_value_text
void
m4_set_symbol_value_text (m4_symbol_value *value, const char *text)