Re: FYI: 28-gary-sanitise-header-includes

[Gary V. Vaughan]

Hi Eric,

On 4 Apr 2007, at 23:58, Eric Blake wrote:
> Gary V. Vaughan <gary <at> gnu.org> writes:
> > Applied to HEAD, after 4 days without comment.
> >
> >   Index: ChangeLog
> >   from  Gary V. Vaughan  <gary <at> gnu.org>
> >         M4 was designed to have a small number of header files defining
> >         the interfaces to several source files each.  Keeping this in
> >         mind allows us to tidy things up considerably.  Having done this,
> >         it becomes clear that some of the installed headers reference
> >         other headers which are not installed (but that's another patch):
> >
> >         * m4/system_.h (gnu/stdio--.h, gnu/stdlib--.h, gnu/unistd--.h):
> >         ...to here, so client modules can benefit too.
> >         (assert.h, errno.h, limits.h, sys/stat.h): Include one here at the
> >         lowest level to save doing it multiple times elsewhere.
> ...
> >         * m4/path.c (config.h, stdlib.h): Ditto.
>
> Oops.  This broke non-debug builds.  Sorry for not catching it sooner.

Mea Culpe.  :-(  Thanks for chasing.

> I am currently playing with a patch that follows gnulib policy of  
> removing
> <config.h> from all .h, and making sure that it is the first line  
> of all .c;
> hopefully that will clean up the problem.  Everything else may be  
> factor-able
> into system_.h, but <config.h> must be handled specially if m4  
> source code is
> to see a consistent state.

Okay, I'll stop futzing with my header install patch until you've  
finished
that.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_ Join my AGLOCO Network: http://www.agloco.com/r/BBBS7912

PGP.sig
Description: This is a digitally signed message part