m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: generate .version in srcdir


From: Jim Meyering
Subject: Re: generate .version in srcdir
Date: Sat, 08 Mar 2008 14:29:57 +0100

Ralf Wildenhues <address@hidden> wrote:
> Hello Eric, Gary,
>
> this fixes a distcheck failure in branch-1_4.  But maybe you're going to
> rewrite GNUmakefile further anyway, in which case you may just want to
> ignore this patch.  ;-)
..
> diff --git a/GNUmakefile b/GNUmakefile
...
>  ifneq ($(_curr-ver),$(VERSION))
> -  _dummy := $(shell echo $(_curr-ver) > .version)
> +  _dummy := $(shell echo $(_curr-ver) > $(srcdir)/.version)
>  endif
>
>  ifneq ($(_created_version_file),1)
> -  _dummy := $(shell test -f .version || echo $(VERSION) > .version)
> +  _dummy := $(shell test -f .version || echo $(VERSION) > $(srcdir)/.version)
>  endif

FYI, a couple days ago I removed those two ifneq clauses
altogether -- from GNUmakefile in coreutils.  With the rule
to create .version in Makefile.am, those two were not needed.

There has been enough churn on this GNUmakefile that it probably
belongs in gnulib.  Then bootstrap could copy it from e.g.,
build-aux/ (though maybe with a different name) to top-level GNUmakefile.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]