m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: improve 'make distcheck'


From: Eric Blake
Subject: [PATCH] maint: improve 'make distcheck'
Date: Mon, 9 Jan 2017 13:53:19 -0600

Commit b29e2867 added gnulib's src/assure.h during bootstrap to fix
development builds, but forgot to check that tarballs also build.

With this patch, things get further, although I'm still facing a
failure because the VPATH 'make check' portion of distcheck is
failing to load modules, where an in-tree build succeeded.

* Makefile.am (src_m4_SOURCES): Add assure.h.

Signed-off-by: Eric Blake <address@hidden>
---

Not sure how to fix the remaining 'make distcheck' failure, but I've
run out of time for today, so I'll push this and see if anyone else
has an idea.

The failures during distcheck look like:

92. modules.at:112: testing --include: absolute path ...
../../../tests/modules.at:112: $M4 -d -I "$abs_builddir" input.m4 < /dev/null
stderr:
gm4:input.m4:2: warning: dumpdef: undefined macro 'test'
gm4:input.m4:3: include: cannot open file 'modtest': No such file or directory

even though _build/sub/tests/.libs/modtest.so exists. I'm not sure
if that means "$abs_builddir" is defined incorrectly.

 Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index 1f38595..c2c9cd3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -123,6 +123,7 @@ MAINTAINERCLEANFILES += \

 bin_PROGRAMS   = src/m4
 src_m4_SOURCES = \
+                 src/assure.h \
                  src/xstrtoul.c \
                  src/xstrtol-error.c \
                  src/xstrtol.c \
-- 
2.9.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]