Re: [Man-db-devel] [PATCH v3] man(1): Fix override dir handling

[Nikola Forró]

On Mon, 2016-12-19 at 21:00 +0500, Mihail Konev wrote:
> Previously, override dir was affecting only some cases
> of manpath determination.
> 
> Apply it only when all paths has been gathered instead.
> (Depending on the definition of when the override dir applies,
> this might not be correct).
> 
> Fixes src/tests/man-9 failing when --with-override-dir=od
> is passed to ./configure.
> 
> Reported-by: Nikola Forró <address@hidden>
> ---
> v3: fix failing the testsuite when --with-override-dir is not
> specified (or specified as an empty string).
> 
>  src/manp.c | 52 +++++++++++++++++++++-------------------------------
>  1 file changed, 21 insertions(+), 31 deletions(-)
> 

Thanks Mihail,

this looks good. However there is another small issue, just try to run
configure with "--with-override-dir=some_dir_with_underscore".
Path with OVERRIDE_DIR appended will not be listed first and the test
will fail.

That's probably because OVERRIDE_DIR is not taken into account
in compare_candidates function.

Regards,
Nikola