[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Maposmatic-dev] [PATCH 3/6] Add a get_bbox_from_osm_id() helper
From: |
Maxime Petazzoni |
Subject: |
Re: [Maposmatic-dev] [PATCH 3/6] Add a get_bbox_from_osm_id() helper |
Date: |
Thu, 5 Aug 2010 09:46:04 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
* Thomas Petazzoni <address@hidden> [2010-08-05 00:54:24]:
> To implement the /papersize/ service, we need to get the bbox
> associated to a given OSM id, so this commit adds a
> get_bbox_from_osm_id() helper.
>
> In fact, the code for this helper already existed in
> check_osm_id(). So we've moved part of check_osm_id() into
> get_bbox_from_osm_id(), which is now used by check_osm_id().
>
> Signed-off-by: Thomas Petazzoni <address@hidden>
> ---
> www/maposmatic/helpers.py | 25 +++++++++++++++----------
> 1 files changed, 15 insertions(+), 10 deletions(-)
LGTM
--
Maxime Petazzoni <http://www.bulix.org>
``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software
signature.asc
Description: Digital signature
- [Maposmatic-dev] [PATCH 1/6] Extend MapRenderingJob with stylesheet, papersize and layout, Thomas Petazzoni, 2010/08/04
- [Maposmatic-dev] [PATCH 2/6] Implement a skeleton /papersize/ service, Thomas Petazzoni, 2010/08/04
- [Maposmatic-dev] [PATCH 3/6] Add a get_bbox_from_osm_id() helper, Thomas Petazzoni, 2010/08/04
- Re: [Maposmatic-dev] [PATCH 3/6] Add a get_bbox_from_osm_id() helper,
Maxime Petazzoni <=
- [Maposmatic-dev] [PATCH 4/6] Add layout, stylesheet and papersize to MapRenderingForm, Thomas Petazzoni, 2010/08/04
- [Maposmatic-dev] [PATCH 6/6] Implement a brand new wizard for map creation, Thomas Petazzoni, 2010/08/04
- [Maposmatic-dev] [PATCH 5/6] Upgrade jquery to 1.4.2, Thomas Petazzoni, 2010/08/04
- Re: [Maposmatic-dev] [PATCH 1/6] Extend MapRenderingJob with stylesheet, papersize and layout, Maxime Petazzoni, 2010/08/05
- [Maposmatic-dev] [PATCH 4/5] Update licence years, Thomas Petazzoni, 2010/08/05
- [Maposmatic-dev] [PATCH 2/5] Add link and form to search maps on the front page, Thomas Petazzoni, 2010/08/05
- [Maposmatic-dev] [PATCH 1/5] Fix maptitle handling in MapRenderingJobForm, Thomas Petazzoni, 2010/08/05