Re: [Maposmatic-dev] [PATCH 1/2] [ocitysmap][i18n] i18n.py: Added two more prefixes to Dutch i18n class

[Jeroen van Rijn]

Thomas,

http://git.savannah.gnu.org/cgit/maposmatic/ocitysmap.git/commit/?id=c663d98b1e2f3bd25ea58732936ec3e3a36d4afb

My apologies, I've spotted a typo in my patch:

u"Ir.", u"Ingenieur", u"Ds.", u"Dominee", u"Deken",

- u"Drs.",

+ u"Drs.", u"Maj.", u"Majoor"

# counting words before street name,

# e.g. "1e Walstraat" => "Walstraat (1e)"

u"\d+e",

There's a missing comma after u"Majoor"

Which reminds me to take on that i18n test suite I'd originally planned some 18 months ago... things certainly can get hectic. :(

On Sun, Apr 1, 2012 at 11:05, Thomas Petazzoni <address@hidden> wrote:

Hello Jeroen!

Le Sun, 1 Apr 2012 10:24:01 +0200,
Jeroen van Rijn <address@hidden> a écrit :

> Signed-off-by: Jeroen van Rijn <address@hidden>
> ---
>  ocitysmap2/i18n.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks a lot, I have applied both of your patches, and they are
now working live on http://dev.maposmatic.org. See:

 http://git.savannah.gnu.org/cgit/maposmatic/ocitysmap.git/commit/?id=c663d98b1e2f3bd25ea58732936ec3e3a36d4afb
 http://git.savannah.gnu.org/cgit/maposmatic/ocitysmap.git/commit/?id=1d29af9591e44e5ecfa41103caa4d30249eafa85

Do you also intend to update the MapOSMatic translation? That would be
nice!

Also, next time, could you send your patches inline? It makes them
easier to apply while keeping your authorship. You can use git
send-email to do so.

Thanks again for your contributions and reactivity!

Thomas
--
Thomas Petazzoni                http://thomas.enix.org
MapOSMatic                      http://www.maposmatic.org
Logiciels Libres à Toulouse     http://www.toulibre.org
Embedded Linux                  http://www.free-electrons.com

-- 
↑↑↓↓←→←→BA[Start]