Re: [Maposmatic-dev] [PATCH] [ocitysmap] Mapnik 2+: update INSTALL and get rid of DeprecationWarning

[Thomas Petazzoni]

Hello,

Le Wed,  4 Apr 2012 12:55:30 +0200,
Jeroen van Rijn <address@hidden> a écrit :

> As of mapnik commit 14700dba16146902ca98fdcacb72b2fba4fa596a,
> using 'import mapnik2' raises a DeprecationWarning.
> See https://github.com/mapnik/mapnik/issues/941 for details.
> 
> Update imports of the mapnik module to use 'import mapnik' and assert
> that the installed version is new enough.
> 
> Tested-by: Jeroen van Rijn <address@hidden>
> Signed-off-by: Jeroen van Rijn <address@hidden>

Thanks, looks good. Are you sure that Mapnik 2.0.0 actually accepts of
being loaded with "import mapnik" ? I thought that Mapnik 2.0.0 could
only be imported with "import mapnik2" and that the change back to
"import mapnik" has been done after the 2.0.0 release (i.e, available
in the Git repo and the upcoming 2.1.0 release).

Can you confirm that?

It's also a bit annoying that this comment+import+assert is duplicated
5 times. Maybe only the imports in coords.py and map_canvas.py are
needed?

Thomas
-- 
Thomas Petazzoni                http://thomas.enix.org
MapOSMatic                      http://www.maposmatic.org
Logiciels Libres à Toulouse     http://www.toulibre.org
Embedded Linux                  http://www.free-electrons.com