Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph

[Volker Grabsch]

Martin Lambers <address@hidden> schrieb:
> I attached a new revision of the OpenSceneGraph patch,

I think that your patch goes into the right direction, and I hope
that upstream will accept your great work.

However, there are some small issues we need to solve.


1) There is a bug which causes a failure of your example
   compile command for "osgstaticviewer":

        .../i686-pc-mingw32/bin/ld: cannot find -losgdb_svg

   Are you able to reproduce and to solve that issue?


2) The command

        i686-pc-mingw32-pkg-config --cflags

   should output the "-DOSG_LIBRARY_STATIC" option. I see two
   possible solutions to that. Please pick the one which appears
   to you being the "right way":


   2a) Change the last line of "packaging/pkgconfig/openscenegraph.pc.in"
       to something like:

            Cflags: @OSG_LIBRARY_STATIC@ -I${includedir}

       where the @OSG_LIBRARY_STATIC@ symbol should be initialized
       to '-DOSG_LIBRARY_STATIC' when DYNAMIC_OPENSCENEGRAPH=OFF and
       to '' (empty string) otherwise.


   2b) Use a $(SED) action in the $(PKG)_BUILD section, such as:

            $(SED) 's,^Cflags:,Cflags: -DOSG_LIBRARY_STATIC,' -i 
'$(1)/packaging/pkgconfig/openscenegraph.pc.in'


   In any case the doc/index.html should be simplified accordingly.


Nevertheless, I performed some cleanup and included your contribution:
http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/965a08983f39

Let's make it work! :-)


Greets,

    Volker

-- 
Volker Grabsch
---<<(())>>---
Administrator
NotJustHosting GbR