|
From: | Rashad M |
Subject: | Re: [Mingw-cross-env-list] update on pull request |
Date: | Mon, 23 Feb 2015 23:51:15 +0100 |
I had some other packages almost ready in system (Monteverdi1, 2, Ice) and I want to add QGIS which is most important for any GIS users. But I want to see if the changes upto now are ok to be merged. So that I can switch to upstream for everything rather than having a detached fork and not getting further updates.--On Wed, Feb 4, 2015 at 4:17 PM, Rashad M <address@hidden> wrote:Hello Tony,Regarding your suggestion on commit:I guess you are talking about this commit
https://github.com/rashadkm/mxe/commit/e71d33693b917ee7c21260dfee020b0ea09ef03fWhen I started mxe to build OTB. I made the first pull request but before Tim's comments on various issue in the pull request. the repository has been in use by daily builds and I couldnt break it for each commit that may result in complete rebuild.So I tried a quick fix by setting a staging repo rather than braching and stuff. So most of the changes happened in second repository[1] (my bad)finally to update pull request I just copied and did a single commit (bad again)So what I am saying is that particular commit is the main reason for need for rebasing. I can close current pull request and create a new one with after style cleanup
In [1] I tried to keep commits in a single units of change
what you think?
[1] https://github.com/bugbrains/mxe/commits/master
- squashing commits to single units of change (“add package openjpeg”, “gdal: enable shared and openjpeg support”, “itk: update, enable shared and libpng tiff jpeg expat support" etc.)--On Mon, Jan 12, 2015 at 12:29 AM, Volker Grabsch <address@hidden> wrote:Rashad M schrieb:
> On Sun, Jan 11, 2015 at 4:12 PM, Volker Grabsch <address@hidden> wrote:
> > Rashad M schrieb:
> > > I am getting below error
> > >
> > > make cleanup-style
> > > make: execvp: bash: Argument list too long
> > > make: *** [cleanup-style] Error 127
> >
> > I have no idea why this is. This command should always work.
Okay, I finally got it.
It's not a single shell command whose argument is too large, but the
whole shell invocation (bash -c) gets a too large argument (script).
Fixed in master as well as stable:
https://github.com/mxe/mxe/commit/dacd2ba109bb588d44eb5432d685077c37a043dc
https://github.com/mxe/mxe/commit/0c6cc9c91cf94e445ec471a5beebb7199483cb9d
Please pull (e.g. "git pull --rebase") and try again.
Regards,
Volker
--
Volker Grabsch
---<<(())>>---
Regards,
RashadRegards,
Rashad
[Prev in Thread] | Current Thread | [Next in Thread] |