Re: [Mingw-cross-env-list] gtk3 patch

[Volker Diels-Grabsch]

Dear Gerardo,

I'm sorry that my comment wasn't helpful to you and left more
questions than answers.  So to clarify:

All MXE developers are following this list.

Moreover, creating an issue on GitHub is very simple and does not
involve creating a pull request.

You are not required to create a pull request, this was just a
proposal to make your contribution easier to review by others and to
speed up inclusion.


Regards,
Volker


Gerardo Ballabio schrieb:
> Hi Volker,
> do you mean that MXE developers aren't following this list any more???
> 
> As I wrote, I don't know how to build a pull request, so I'd appreciate if
> someone else will kindly do it.
> If nobody volunteers, I guess I'll eventually try and learn how to do it
> myself.
> 
> Gerardo
> 
> 
> 2017-11-08 12:14 GMT+01:00 Volker Diels-Grabsch <address@hidden>:
> 
> > Dear Gerardo,
> >
> > In case you don't get a timely response on this list, I propose to
> > open an issue on GitHub.  Ideally, also propose a pull request, which
> > is the fastest way to get code included.
> >
> > https://github.com/mxe/mxe
> >
> > https://help.github.com/articles/creating-a-pull-request/
> >
> >
> > Regards,
> > Volker
> >
> >
> > Gerardo Ballabio schrieb:
> > > Resending without big attachment (gtk3-2-builtinicons.patch), uploaded
> > > here:
> > > https://drive.google.com/drive/folders/1d0PlU794aVxT97zFMGySRa_
> > vpxrM8J7b?usp=sharing
> > >
> > > 2017-11-06 20:37 GMT+01:00 Gerardo Ballabio <address@hidden
> > >:
> > >
> > > > Hello,
> > > > please add the attached patch file to MXE.
> > > >
> > > > It solves the problem of GTK+ standard icons not being available if an
> > > > icon theme isn't installed on the target machine. This also means that
> > some
> > > > standard widgets (GtkSpinButton, GtkComboBoxText, possibly others)
> > which
> > > > rely on the icons aren't displayed correctly. The attached test file
> > > > demonstrates the problem.
> > > >
> > > > The patch restores the builtin icons that used to be provided by GTK+
> > > > until version 3.12, but were removed in the 3.14 release. It's large
> > > > because it adds back a file which contains the icon pixmaps packed in a
> > > > 400+ kbytes character array.
> > > >
> > > > With this patch, a static executable built with MXE and copied to a
> > > > Windows machine will "just work" without requiring to install also an
> > icon
> > > > theme.
> > > >
> > > > I don't know git, so can you please build the pull request.
> > > >
> > > > Thank you
> > > >  Gerardo
> > > >
> > > >
> >
> >
> >
> > --
> > Volker Diels-Grabsch
> > ----<<<((()))>>>----
> >
> >

-- 
Volker Diels-Grabsch
----<<<((()))>>>----