[Mldonkey-users] [patch #4709] Fix zip file extract broken due to patch 4694 (Ocaml 3.09)

[z]

Update of patch #4709 (project mldonkey):

                  Status:                    Done => None                   
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #2:

What is the theory behind this patch and patch 4694 that you think makes the
code better rather than worse?

They seem to remove pertinent information from the source.   For example,
lines like:

-      let version_made_by = read2 ic in
-      let version_needed = read2 ic in

are now

let _ = read2 ic in
let _ = read2 ic in

One used to be able to figure out what the bytes were based on variable names
in the code.  This identified/documented file formats. Now they are not
knowable.

Patch 4694 removed many lines like "let kind = get_uint8 s 22 in" which
helped identify what the bytes in the buffer were ("kind") even if not
currently used, which documented the various protocols, but now that
information is lost.



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4709>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/