Re: Monitoring Apache mod_status (was Apache, rotatelogs & chroot environment)

[Martin Pala]

Looks good :)

I have only few notes:


1.) the limits in the patch are defined as percentage, but it is not 
obvious at first sigth. Currently '%' character is used in monit control 
file for other tests where percentage limit is supported (cpu, memory, 
inode, space), such as:

  if space usage > 80% then alert

=> maybe it could be better to change (example):

  if failed port 80
     protocol apache-status dnslimit 25 then alert

to:

  if failed port 80
     protocol apache-status dnslimit 25% then alert


2.) it could be good to support comparision operators as well, so it 
will be possible to use various combinations. It will be more consitent 
with other tests syntax too (such as in the case of 'space' example 
above). We can then check for example that there are always 10% child 
processes waiting for connection (i.e. ready to serve requests immediately):

  if failed port 80
     protocol apache-status waitlimit < 10% then alert

This will allow to stack the actions too based on various error levels:

  if failed port 80
     protocol apache-status loglimit > 50% then alert
  if failed port 80
     protocol apache-status loglimit > 90% then restart


3.) and one cosmetic note - the '*limit' statements (loglimit, 
waitlimit, ...) are appropriate for current patch implementation (it 
realy defines limit), however in the case that point 2. above will be 
implemented, it will be not exact name form for these options. Maybe 
there could be more natural name form for these options (but i'm not 
sure which).


Good work :)
Martin

David Fletcher wrote:

> Hi,
>
> Here is are the code and documenation patchs for monitoring Apache's mod_status
> that has been discussed on the Monit-General list.
>
> I hope that it survives line wrapping - some of the lines were 80 characters,
> but have been made a little longer by the patch creation. Some of the "diff"
> file name lines also extend beyond 80 characters.
>
> The first patch is for the Monit 4.4 code, the second is for the monit.dep
> documentation file.
>
> David.