Re: [PATCH] ICMP with optional host parameter

[Michel Marti]

Martin Pala wrote:
> Thanks for patch, however i think you can reach the same result using 
> either dependency on 'host' service or exec action. 
Correct... However it complicates the monit-configuration a little bit. In my 
opinion, the ICMP check is similar to other network tests (e.g. "if failed host 
myhost port 1234 ..."). So it should aswell have a "host" parameter.

> I think the process service container should be kept only for process 
> properties (icmp testis is logicaly not related to the process).
So is the "loadavg()" test but it can still be used for process services?!?

> - extend restart and similar monit actions by optional argument which 
> may specify monit's service name (to bypass the exec trick)
>   IF FAILED <test> THEN {<action> [<service>], ...}
> What do you think?
Sounds good...

Could you consider keeping at least the DEBUG statement in validate.c from my 
patch (this gives users a clue that a IMCP test has been started when running 
monit in debug mode (-v)):


+        DEBUG("'%s' sending ICMP echo request to with timeout %d\n",
+            s->name, icmp->timeout);


Michel