|
| From: | Alex Kelly |
| Subject: | RE: [monit-dev] Monit HTTP Server non-tables based layout |
| Date: | Wed, 6 Feb 2008 02:12:00 -0000 |
|
Hi Jan-Henrik, I’ve made a few more tweaks to the code so
that it now produces HTML which validates in the W3C checker. I assume you need
to check the patch from a security perspective. Would it therefore be better
for you if I provide a second patch, against the patched code, so there are fewer
lines needing to be checked? Regards, Alex From:
address@hidden
[mailto:address@hidden On Behalf Of Jan-Henrik Haukeland Thanks, this looks like a real improvement. Just need to check the
patch a bit more. On 30. jan.. 2008, at 20.08, Alex Kelly wrote:
Hi All, As this is my first post to the list I’d
like to thank everyone who’s had a hand in producing monit. I’m sure it’s saved
my bacon on many an occasion so I can’t express my gratitude enough. I use monit on a whole bunch of my
servers, and was recently in a position where I wanted to check up on a service
using the my mobile. It wasn’t to pleasant trying to navigate the tables based
layout that monit currently uses. I had a bit of a look search the posts on the
users and dev mailing lists but couldn’t find anything other than one or two
requests for a more modern approach to the markup. So…I’ve had a bit of a
fiddle with the html output by the server and think I’ve come up with something
that’s at least worth posting to get some feedback. I’m sure that it could be
tweaked more, but the attached patch produces a very similar rendering on
screen to the current monit HTML, but is based on a semantically marked up
content with some css. It also includes separate stylesheets for screen and
mobile use, as that was what prompted me to look at it in the first place. I’ve bodged in some new fnuctions which
serve the css as ‘_css’, ‘_screencss’ and ‘_mobilecss’ for now. I think it’d be
a nice feature if it’d be possible to specify the stylesheets as parameters in
monitrc and then serve up those files. That way users could edit the css to fit
their needs without having to delve into the source. Thought I’d get feed back
on the general principle before going there though. I guess this could be something that has
come up in the past and been dismissed for some reason. Hopefully not though,
in which case this patch may be of use. Regards, Alex Kelly !DSPAM:47a0e64a284378697011158! No virus found in this incoming message.
No virus found in this outgoing message. |
| [Prev in Thread] | Current Thread | [Next in Thread] |