[monit-dev] [monit] r287 committed - Experimental: it seems monit sporadically reads its own ICMP echo requ...

[monit]

Revision: 287
Author: martin2812
Date: Sun Sep 26 11:45:11 2010
Log: Experimental: it seems monit sporadically reads its own ICMP echo  
request if the request is sent to the
same host's network interface (such as for virtual hosts running on the  
same machine), whereas the raw
socket seems to read it before target host gets the request.

Need to investiagte it more.

To verify whether the theory is right, trying to delay the read to see if  
there will be difference - we
see the transient 1/3 attempt failure sporadically on testing farm. Will  
deploy this to farm and verify
the behavior.


http://code.google.com/p/monit/source/detail?r=287

Modified:
 /trunk/net.c

=======================================
--- /trunk/net.c        Thu Sep 16 05:13:58 2010
+++ /trunk/net.c        Sun Sep 26 11:45:11 2010
@@ -738,6 +738,13 @@
       continue;
     }

+    /* Experimental: it seems monit sporadically reads its own ICMP echo  
request if the request is sent to the
+     * same host's network interface (such as for virtual hosts running on  
the same machine), whereas the raw
+     * socket seems to read it before target host gets the request. Need  
to investiagte it more, trying to delay
+     * the read to see if there will be difference (we see the transient  
1/3 attempt failure sporadically on testing
+     * farm */
+    usleep(100);
+
     if (can_read(s, timeout)) {
       socklen_t size = sizeof(struct sockaddr_in);