Re: [Monotone-debian] Monotone completely broken in Debian testing (I think)

[Richard Levitte]

I can confirm this on sid as well.  It surprises me that I didn't
notice before now...

... and after comparing the source for 1.10.1 and 1.10.2, I think I
found an unfortunate ABI change:

--- Botan-1.10.1/src/alloc/secmem.h     2011-07-11 19:32:23.000000000 +0200
+++ Botan-1.10.2/src/alloc/secmem.h     2012-06-17 20:50:48.000000000 +0200
@@ -164,19 +164,20 @@
       */
       void swap(MemoryRegion<T>& other);
 
-      ~MemoryRegion() { deallocate(buf, allocated); }
+      virtual ~MemoryRegion() { deallocate(buf, allocated); }


(yeah, there's more changes in that file, but the rest is safe)
This is something that we use in monotone.  Not sure if it was
MemoryRegion directly or one of its subclasses, but still, this change
would logically bring on a SIGSEGV any time an instance of that class
(or one of its subclasses) is destroyed, or any time a virtual method
that's below the slot for the destructor gets called...

Cheers,
Richard

In message <address@hidden> on Mon, 09 Jul 2012 22:19:11 +0100, Francis Russell 
<address@hidden> said:

francis> Monotone broke for me completely today in that I couldn't even run mtn
francis> with no options on my x86_64 Debian testing system. Based on the
francis> backtrace I got from GDB and my APT logs, it looks like the upgrade of
francis> libbotan1.10-0 from 1.10.1-1 to 1.10.2-1 is the culprit:
francis> 
francis> address@hidden:~$ gdb /usr/bin/mtn
francis> GNU gdb (GDB) 7.4.1-debian
francis> Copyright (C) 2012 Free Software Foundation, Inc.
francis> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/
francis> This is free software: you are free to change and redistribute it.
francis> There is NO WARRANTY, to the extent permitted by law.  Type "show co
francis> and "show warranty" for details.
francis> This GDB was configured as "x86_64-linux-gnu".
francis> For bug reporting instructions, please see:
francis> <http://www.gnu.org/software/gdb/bugs/>...
francis> Reading symbols from /usr/bin/mtn...(no debugging symbols found)...d
francis> (gdb) run
francis> Starting program: /usr/bin/mtn
francis> [Thread debugging using libthread_db enabled]
francis> Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.
francis> 
francis> Program received signal SIGSEGV, Segmentation fault.
francis> 0x00000000005cf99c in Botan::SHA_160::~SHA_160() ()
francis> (gdb) bt
francis> #0  0x00000000005cf99c in Botan::SHA_160::~SHA_160() ()
francis> #1  0x00007ffff77f8b66 in Botan::Hash_Filter::~Hash_Filter() () from
francis> #2  0x00007ffff780ddec in Botan::Pipe::destruct(Botan::Filter*) () f
francis> #3  0x00007ffff780de58 in Botan::Pipe::~Pipe() () from /usr/lib/libb
francis> #4  0x00007ffff78cfdb3 in ?? () from /usr/lib/libbotan-1.10.so.0
francis> #5  0x00007ffff78d06b0 in Botan::algorithm_kat(Botan::SCAN_Name
francis> conslocator<std::pair<std::string const, std::string> > > const&, 
Botan:
francis> #6  0x00007ffff78d4b43 in ?? () from /usr/lib/libbotan-1.10.so.0
francis> #7  0x00007ffff78d5603 in Botan::confirm_startup_self_tests(Botan::A
francis> #8  0x00007ffff7836257 in Botan::Library_State::initialize(bool) ()
francis> #9  0x00007ffff7834df4 in Botan::LibraryInitializer::initialize(std:
francis> #10 0x00000000006d7b3a in ?? ()
francis> #11 0x00000000004193ba in ?? ()
francis> #12 0x00007ffff6288ead in __libc_start_main (main=<optimized out>, a
francis>     fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ff
francis> #13 0x0000000000419491 in ?? ()
francis> #14 0x00007fffffffe208 in ?? ()
francis> #15 0x000000000000001c in ?? ()
francis> #16 0x0000000000000001 in ?? ()
francis> #17 0x00007fffffffe53a in ?? ()
francis> #18 0x0000000000000000 in ?? ()
francis> (gdb)
francis> 
francis> Once I rebuilt the package, mtn worked fine so I guess Botan made some
francis> incompatible ABI change. Can someone else confirm what I've seen?
francis> Unfortunately, the only other thing that uses botan1.10-0 is softhsm as
francis> I couldn't convince it to do anything that confirmed the issue was with
francis> Botan.
francis> 
francis> What's the easiest way to get this fixed?
francis> 
francis> Francis
francis> 
francis> _______________________________________________
francis> Monotone-debian mailing list
francis> address@hidden
francis> https://lists.nongnu.org/mailman/listinfo/monotone-debian