[Monotone-devel] Re: fetch problems

[graydon hoare]

Peter Simons wrote:
> When trying to update my monotone repository, I get this
> error:
>
>  | peti:/usr/local/src/monotone-current$ monotone fetch
>  | monotone: fetching packets from group 
> http://www.off.net/monotone/depot.cgi/monotone
>  | monotone: warning: misuse: Bad char from network: pos 428, char '45'
>  | 
>  | monotone: fetched 0 packets
>  | monotone: warning: errors occurred during fetches
>
> Any idea what is going wrong?

ugh, yeah. tromey mailed me a patch which enabled '-' as a legal 
character in http packet streams (it should have been, anyways) and that 
patch was committed to my depot, to support tromey's auto-tester (which 
has a hyphen in its email address). unfortunately he started *using* the 
address immediately (he posts to the same depot) so there are packets in 
there, now, which have hyphens.

the easy thing to do is just open up http_tasks.cc and add a '-' to the 
set of accepted characters. here's the hunk you need to apply:

--- http_tasks.cc
+++ http_tasks.cc
@@ -140,7 +140,7 @@
   size_t pos = tmp.find_first_not_of("abcdefghijklmnopqrstuvwxyz"
                                     "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
                                     "0123456789"
-                                    "+/address@hidden \n\t");
+                                    "-+/address@hidden \n\t");
   N(pos == string::npos,
     F("Bad char from network: pos %d, char '%d'\n")
     % pos % static_cast<int>(tmp.at(pos)));


or alternatively, fetch the packet stream you need with wget first, 
update and rebuild, like so:

 $ wget -O - \
  'http://www.off.net/monotone/depot/monotone?q=since&major=0&minor=0' \
   | monotone read
 $ monotone update
 $ make

sorry, this upgrade should have been given time to trickle out to users, 
before being put to use.

-graydon