[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Re: [patch] roster-deltas (40% pull speedup)
From: |
Eric Anderson |
Subject: |
Re: [Monotone-devel] Re: [patch] roster-deltas (40% pull speedup) |
Date: |
Wed, 23 Aug 2006 14:20:36 -0700 |
Nathaniel Smith writes:
> [ concern about possible mistake in roster delta code ]
So is it worth storing the full rosters as well, but only using them
intermittently, e.g. test 10% of all rosters by comparing with the
full stored roster, and checking all of them on a db check? If you do
binary rosters and skip the SHA1, this will probably not cost that
much (still have to do the xdelta bits, but making the binary roster
itself from the data structure is pretty quick). If you do the SHA1,
it probably won't be much of a win, but it would allow for more solid
checking on everyone's usage, and recovery in the cases where
something goes wrong.
-Eric