Re: [Monotone-devel] Please review quickly [Fwd: [bug #19137] permissions on ~/.monotone/keys/ are too permissive]

[Nathaniel Smith]

On Wed, Apr 11, 2007 at 08:16:38PM +0200, Markus Schiltknecht wrote:
> --- key_store.cc        70b97a9e2a06654ec641a1709c2a875cdfa603d5
> +++ key_store.cc        fda46d5fa8a5b2a52421c1f83413a208e2c6401f
> @@ -1,4 +1,5 @@
>  #include <sstream>
> +#include <sys/stat.h>
> 
>  #include "key_store.hh"
>  #include "file_io.hh"
> @@ -210,8 +211,12 @@ key_store::write_key(rsa_keypair_id cons
>    data dat(oss.str());
>    system_path file;
>    get_key_file(ident, file);
> +
> +  // set a restrictive umask, write the file and reset umask
> +  mode_t mask = umask(S_IRWXG|S_IRWXO);
>    L(FL("writing key '%s' to file '%s' in dir '%s'") % ident % file % 
> key_dir);
>    write_data(file, dat, key_dir);
> +  umask(mask);
>  }

What will this do on win32?

It would also be better to set/unset the umask via a handle object,
for correctness wrt exception.  (Not that we tend to use exceptions,
but yeah.)

-- Nathaniel

-- 
"If you can explain how you do something, then you're very very bad at it."
  -- John Hopfield