Re: [Monotone-devel] "throw usage(); " or "N(); " for argument checking?

[LeJacq, Jean Pierre]

On Saturday 2009 January 03 20:56:52 Timothy Brownawell wrote:
> Many commands check for eg the right number of arguments like so:
>
>   if (args.size() != 3)
>     throw usage(execid);
>
> where others do
>
>   N(args.size() == 0,
>     F("no arguments needed"));
>
>
> This ought to be made consistent, does anyone object to using the
> 'throw usage();' version everywhere?

I recommend the inverse. Exceptions should be reserved for, well
"exceptional" situations. Validation of inputs doesn't fall into
this category and is more properly handled by normal control loops.

-- 
JP