On Sat, Mar 7, 2009 at 11:31 PM, Felipe Contreras
<address@hidden> wrote:
This improves performance while exporting. In my system I see an
improvement from 52 minutes to 6 seconds.
I do see quite a big performance improvement with this patch as well, although not nearly as dramatic as your 52 minutes down to 6 seconds. Exporting my monotone database takes ~26 minutes without this patch and ~17 minutes with it, so there is about 9 minutes of cert loading time which certainly needs fixing.
I've also tested against pidgin, xaraya and OE databases and it shaves about 30 minutes off of each of those as well. For pidgin and xaraya this cuts the export time almost in half. OE takes *forever* to export though (12 hours or so) so cutting 30 minutes off doesn't make such a big difference. I think OE has lots more active files and much larger rosters but I haven't really looked into why it's so slow.
So, I'm *really* curious as to exactly what you're testing to get this speedup. Can you provide some more details?
I don't have any objections to this patch and I'll probably commit it later today, after poking around a bit more to see why in the heck loading certs by name is as slow as it is.
I did have to make a few adjustments to the patch as I've merged the fast-export branch back to net.venge.monotone and a few minor things have changed there. patch(1) also didn't like this patch and I had to apply it by hand. Is there some know problem with git-format-patch (assuming that's what you're using) that produces patches that patch(1) doesn't like?
Thanks,
Derek