[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] Updated Issue 180 - monotone-1.0: bash_completion test
From: |
code |
Subject: |
[Monotone-devel] Updated Issue 180 - monotone-1.0: bash_completion test FAIL (monotone) |
Date: |
Sat, 10 Sep 2011 01:50:48 +0200 |
Hello,
The following issue has been updated:
180 - monotone-1.0: bash_completion test FAIL
Project: monotone
Status: Fixed
Reported by: Peter Volkov
URL: https://code.monotone.ca/p/monotone/issues/180/
Labels:
Type:Defect
Priority:Medium
Comments (last first):
# By Richard Levitte, Sep 10, 2011:
Ok, patch applied. Thanks!
Revision 3d073d7ef08bfbe9f93dc2b6131486cc6e2f6aec
Status: Fixed
# By Peter Volkov, Sep 7, 2011:
We are using bash-completion for this site:
http://bash-completion.alioth.debian.org/
That said I've tracked what causes this test failure. In Gentoo bash-completion
package just installs
/etc/profile.d/bash-completion.sh script, which you can see here:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-shells/bash-completion/files/bash-completion.sh-gentoo-1.2?revision=1.1&view=markup
and files into /usr/share/bash-completion/.
By default this script does nothing (see script: _load_completions loads .pre
and base only in case at least one script is in "/etc/bash_completion.d/"*
~/.bash_completion.d/* or ~/.bash_completion .) So user must enable at least
some bash completion to make it load basic definitions from
/usr/share/bash-completion/.pre (where _get_comp_words_by_ref is defined) and
enable base (for _longopt). Also this all works only for interactive bash, like
it should.
So now I propose the patch in attachment that loads all required
bash-completion functions from /usr/share/bash-completion/.pre and
/usr/share/bash-completion/base and with this patch tests succeed. Please,
apply.
Attachments:
- monotone-1.0-bash_completion-bashrc-1.0.patch - 766 bytes
https://code.monotone.ca/p/monotone/issues/view/attachment/28/monotone-1.0-bash_completion-bashrc-1.0.patch
# By Richard Levitte, Sep 6, 2011:
Hmmm, the extra log suggests Gentoo has a different bash-completion version
than I've played with. The function _split_longopt isn't there, which breaks
the monotone completion script...
I'll see what I can do about that...
Peter, what Gentoo version are we talking about? And bash-completion version?
# By Richard Levitte, Sep 6, 2011:
Yup, I'll have a look
# By Thomas Keller, Sep 6, 2011:
Hrm... apparently Gentoo uses a different version of bash_completion. Peter,
could you please attach the Gentoo version here?
@Richard: Could you have a look what is missing there...? Thanks!
Owner: levitte
# By Peter Volkov, Sep 5, 2011:
Gentoo uses different place for bash_completion test. Please, attach patch in
attachment, so monotone test suite was able to find it. But even with this
patch tests fail (please, see extra.log).
Attachments:
- monotone-1.0-bash_completion-bashrc.patch - 512 bytes
https://code.monotone.ca/p/monotone/issues/view/attachment/25/monotone-1.0-bash_completion-bashrc.patch
- extra.log - 20.68 kB
https://code.monotone.ca/p/monotone/issues/view/attachment/26/extra.log
--
Issue: https://code.monotone.ca/p/monotone/issues/180/