[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] issue 201; missing certs are easily generated, but
From: |
Stephen Leake |
Subject: |
Re: [Monotone-devel] issue 201; missing certs are easily generated, but reported as a serious problem |
Date: |
Sun, 24 Jun 2012 11:33:45 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (windows-nt) |
Stephen Leake <address@hidden> writes:
> One fix is very simple; in database_check.cc, take missing_certs out of
> the 'serious' sum. Then 'db check' reports:
>
> mtn: revision 114f6aa58c7707bf83516d4080ca6268c36640ad missing branch cert
> mtn: warning: 1 missing certs
> mtn: check complete: 2 files; 2 rosters; 2 revisions; 1 keys; 7 certs; 3
> heights; 1 branches
> mtn: total problems detected: 1 (0 serious)
> mtn: minor problems detected
>
>
> On the other hand, perhaps some certs are more important than others? We
> could count branch certs separately from author and date, and then just
> leave missing_branch_certs out of the 'serious' sum.
Another fix, as the problem report suggests, is to change the netsync
code to pull all certs for a revision; only use the branch filter to
decide which revision to pull.
--
-- Stephe