nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] Bugs in global.c:toggle_init and nano.c:do_enter


From: David Benbennick
Subject: Re: [Nano-devel] Bugs in global.c:toggle_init and nano.c:do_enter
Date: Sat, 13 Apr 2002 14:15:52 -0400

Oops, I didn't explain very well.  I didn't change configure.ac or the
meaning of the --enable-tiny switch, which defines NANO_SMALL and
DISABLE_*.  What I did is clean up a few #ifdef's in the C code.  For
example, nano.c:help_init, which is compiled only if !DISABLE_HELP,
refers to the global toggles variable, which is defined only if
!NANO_SMALL.  So when you turn on NANO_SMALL and turn off DISABLE_HELP,
it breaks.

The few problems I found were caused by confusion over what NANO_SMALL
really means.  NANO_SMALL being turned on currently means there is:

* no libintl.h or gettext()
* no cut mark, ^^
* no cut-from-cursor, -k --cut
* no file conversion, --dos --mac --noconvert
* no command execution, ^R^X
* no toggles
* no find-other-bracket, M-]
* no smooth scrolling, -S
* no autoindent, -i
* no go-to-next-word, ^<Space> or M-<Space>
* no terminal resizing (nano.c:handle_sigwinch)


On Sat, Apr 13, 2002 at 12:37:44PM -0400, Rocco Corsi wrote:   <snip>
> Do we need some new switches?  NANO_SMALLISH  or  NANO_VERY_SMALL.  :)

Well, not that I can see.


While I'm at it, here is another question.  The strings

        "add_to_cutbuffer called with inptr->data = %s\n"
        "Blew away cutbuffer =)\n"
        "filename is %s"
        "Wrote >%s\n"
        "delete_node(): free'd a node, YAY!\n"
        "delete_node(): free'd last node.\n"
        "delete_opennode(): free'd a node, YAY!\n"
        "delete_opennode(): free'd last node.\n"
        "check_wrap called with inptr->data=\"%s\"\n"
        "current->data now = \"%s\"\n"
        "After, data = \"%s\"\n"
        "Main: set up windows\n"
        "Main: bottom win\n"
        "Main: open file\n"
        "I got Alt-0-%c! (%d)\n"
        "I got Alt-[-1-%c! (%d)\n"
        "I got Alt-[-2-%c! (%d)\n"
        "I got Alt-[-%c! (%d)\n"
        "I got Alt-%c! (%d)\n"
        "I got %c! (%d)\n"
        "parse_rcfile: Read a comment\n"
        "parse_rcfile: Parsing option %s\n"
        "set flag %d!\n"
        "unset flag %d!\n"
        "actual_x_from_start for xplus=%d returned %d\n"
        "Aha! \'%c\' (%d)\n"
        "input \'%c\' (%d)\n"
        "Moved to (%d, %d) in edit buffer\n"
        "current->data = \"%s\"\n"
        "I got \"%s\"\n"
        "do_cursorpos: linepct = %f, bytepct = %f\n"

are all used only if DEBUG is defined.  They are translated, with _(...)
around them! It seems like a silly idea to translate these messages,
given that you need English to read the actual code anyway.  (And what
else is the point of debugging messages?) If nobody comments, in a week
or so I will submit a patch removing the _()s from around these strings.



David

Attachment: pgpXAgc_dPii4.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]