Re: [Nano-devel] [PATCH] Update gentoo.nanorc

[Davide Pesavento]

On Mon, Jan 26, 2009 at 01:34, Mike Frysinger <address@hidden> wrote:
> On Saturday 24 January 2009 12:57:19 Davide Pesavento wrote:
>> please consider the attached patch for inclusion.
>> It expands the Gentoo syntax highlighting file with many new definitions.
>
> the QA_.* match is overly complicated.  i would just match [-[:alnum:]] rather
> than trying to maintain a valid keyword list.

Why shouldn't we be more precise if it's possible? And I don't think
the list of valid arches will change so often...

>
> you should add CPPFLAGS to the toolchain variable list as well

OK. I'll also add:
  - WANT_(AUTOCONF|AUTOMAKE)
  - AT_M4DIR
  - e(autoreconf|aclocal|autoheader|autoconf|automake)

>
> otherwise looks fine, thanks
> -mike
>

Thanks for reviewing,
Davide