[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Nano-devel] nano uses an unportable Makefile construct.
From: |
Eitan Adler |
Subject: |
[Nano-devel] nano uses an unportable Makefile construct. |
Date: |
Thu, 19 Feb 2009 19:40:21 -0500 |
User-agent: |
Mozilla (X11; U; FreeBSD i386; en-US; ) Gecko Thunderbird Mnenhy/0.7.6.666 |
Christian Weisgerber and I noticed that nano uses a gnu make specific
feature.
Christian Weisgerber tried sending this email to this list but is not
subscribed.
From: Christian Weisgerber <address@hidden>
To: address@hidden
Subject: Unportable Makefile construct
nano uses an unportable Makefile construct.
The use of a $< outside a suffix rule is a GNU make extension and breaks
with other make implementations. This needs to be replaced with $?, or
better yet, spell out the source file explicitly.
Makefile.in
=======================================
--- doc/man/Makefile.in.orig
+++ doc/man/Makefile.in
@@ -630,11 +630,11 @@
630
631
address@hidden@nano.1.html:·nano.1
address@hidden@» groff·-t·-mandoc·-Thtml·<·$<·>·$@
address@hidden@» groff·-t·-mandoc·-Thtml·<·$?·>·$@
address@hidden@nanorc.5.html:·nanorc.5
address@hidden@» groff·-t·-mandoc·-Thtml·<·$<·>·$@
address@hidden@» groff·-t·-mandoc·-Thtml·<·$?·>·$@
address@hidden@rnano.1.html:·rnano.1
address@hidden@» groff·-t·-mandoc·-Thtml·<·$<·>·$@
address@hidden@» groff·-t·-mandoc·-Thtml·<·$?·>·$@
638#·Tell·versions·[3.59,3.63)·of·GNU·make·to·not·export·all·variables.
639#·Otherwise·a·system·limit·(for·SysV·at·least)·may·be·exceeded.
640.NOEXPORT:
Makefile.in
=======================================
--- doc/man/fr/Makefile.in.orig
+++ doc/man/fr/Makefile.in
@@ -434,11 +434,11 @@
434
435
436nano.1.html:·nano.1
-437» groff·-t·-mandoc·-Thtml·<·$<·>·$@
+437» groff·-t·-mandoc·-Thtml·<·$?·>·$@
438nanorc.5.html:·nanorc.5
-439» groff·-t·-mandoc·-Thtml·<·$<·>·$@
+439» groff·-t·-mandoc·-Thtml·<·$?·>·$@
440rnano.1.html:·rnano.1
-441» groff·-t·-mandoc·-Thtml·<·$<·>·$@
+441» groff·-t·-mandoc·-Thtml·<·$?·>·$@
442#·Tell·versions·[3.59,3.63)·of·GNU·make·to·not·export·all·variables.
443#·Otherwise·a·system·limit·(for·SysV·at·least)·may·be·exceeded.
444.NOEXPORT:
--
Eitan Adler
"Security is increased by designing for the way humans actually behave."
-Jakob Nielsen
- [Nano-devel] nano uses an unportable Makefile construct.,
Eitan Adler <=
Re: [Nano-devel] nano uses an unportable Makefile construct., Chris Allegretta, 2009/02/25