[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] nano uses an unportable Makefile construct.
From: |
Eitan Adler |
Subject: |
Re: [Nano-devel] nano uses an unportable Makefile construct. |
Date: |
Thu, 19 Feb 2009 21:16:38 -0500 |
User-agent: |
Mozilla (X11; U; FreeBSD i386; en-US; ) Gecko Thunderbird Mnenhy/0.7.6.666 |
Mike Frysinger wrote:
> On Thursday 19 February 2009 20:46:01 Eitan Adler wrote:
>> Mike Frysinger wrote:
>>> On Thursday 19 February 2009 19:40:21 Eitan Adler wrote:
>>>> The use of a $< outside a suffix rule is a GNU make extension and breaks
>>>> with other make implementations. This needs to be replaced with $?, or
>>>> better yet, spell out the source file explicitly.
>>> or better yet, go install GNU make
>> Why require an entirely new program for a) something that can fixed by
>> one small change b) can be fixed upstream?
>> Why use a vendor specific extension when using a portable method is
>> trivial?
>
> GNU make is available everywhere. install it and be done. i may also point
> out nano is a GNU project.
> -mike
I'm aware that I could add an extra dependency, forcing users to
download, compile, and install yet another program. I am also aware
that there is a trivial patch that fixes the issue and makes the
Makefile portable.
I don't really care that much if you accept this patch or not. I could
easily patch the port without it being accepted upstream. Its just like
using valid XHTML though - no reason not to use the standards.
Eitan Adler
freeBSD nano-devel ports maintainer
Re: [Nano-devel] nano uses an unportable Makefile construct., Chris Allegretta, 2009/02/25