[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH 2/3] silence unused shush warning
|
From: |
Mike Frysinger |
|
Subject: |
Re: [Nano-devel] [PATCH 2/3] silence unused shush warning |
|
Date: |
Sun, 6 Nov 2011 17:46:53 -0500 |
|
User-agent: |
KMail/1.13.7 (Linux/3.1.0-rc4; KDE/4.6.5; x86_64; ; ) |
On Sunday 06 November 2011 16:32:03 Eitan Adler wrote:
> On Sun, Nov 6, 2011 at 12:51 PM, Mike Frysinger <address@hidden> wrote:
> > Newer gcc warns about set-but-unused variables, so add a dummy if()
> > check to kill that off.
>
> Please don't do this. It is better to check shush each time for -1.
the code intentionally does this. the comment explains why.
-mike
signature.asc
Description: This is a digitally signed message part.
Re: [Nano-devel] [PATCH 1/3] delete unused dirnamelen variable, Eitan Adler, 2011/11/06