Re: [Nano-devel] http://www.nano-editor.org/dist/test/nano-2.3.2pre1.tar.gz

[Chris Allegretta]

On Wed, Jan 2, 2013 at 12:04 PM, Eitan Adler <address@hidden> wrote:

On 2 January 2013 10:39, Chris Allegretta <address@hidden> wrote:
> Also, I'm already aware that the locking implementation means you
> can't edit files in directories you cant write to without turning
> locking off; all other bugs reports are still welcome.  Apologies for
> that oversight!

Other than this issue I've been testing it and it seems nice.
Personally I'd like a config option for a locks directory but this is
a feature request, not a bug report.

> On Wed, Jan 2, 2013 at 10:37 AM, Chris Allegretta <address@hidden> wrote:
>> I'm still relatively inexperienced with git but like what I've seen
>> since coming into contact with it for other work.  Let me see about
>> setting it up in Savannah; as long as it's not a hard cut and I can
>> screw up the repo a few times before moving from SVN officially this
>> sounds fine.

Git is cool.  I've been personally using "git svn" for this task.
Upstream on svn or git doesn't bother me either way.

>> Also this is a good time to remind me if folks have been maintaining
>> downstream things for your distro and you want to push them up; a URL
>> is preferred to a giant number of attachments in a private reply :)

FreeBSD has
http://svnweb.freebsd.org/ports/head/editors/nano/files/patch-doc_man_Makefile.in?view=co
http://svnweb.freebsd.org/ports/head/editors/nano/files/patch-doc_man_fr_Makefile.in?view=co 

http://svnweb.freebsd.org/ports/head/editors/nano-devel/files/patch-doc_man_nanorc.5?view=co

Hmm this is taking a lot longer than I'd have hoped.  I'll keep on this as it seems like it shouldnt be this hard to figure out... unsure how easy fixing the last would be, ideally we'd turn it into a .in file and actually generate the path based on the install prefix.

 

Other patches outstanding (lacking an ack) from me.
https://lists.gnu.org/archive/html/nano-devel/2011-11/msg00004.html

r4553

https://lists.gnu.org/archive/html/nano-devel/2011-11/msg00005.html

err, I see lots of warning wih slang (assuming that's what you meant), it seems slang thinks that the string argument to waddnstr is char * but ncurses think its const char *.  But since you brought it up I fixed some other issues with -Wall and -pedantic in r4555

 

https://lists.gnu.org/archive/html/nano-devel/2011-02/msg00005.html

Unable to reproduce with the g++ I tried (gcc version 4.4.5) but I introduced new problems with the locking code so I fixed those. r4556

 

http://marc.info/?l=nano-devel&m=132072059824309 

http://marc.info/?l=nano-devel&m=132072107124403

included included in r4557

I didn't verify these patches haven't been applied yet.  Sorry.

Other outstanding issues that don't relate to the code:

http://www.nano-editor.org/dist/v2.2/faq.html#1.6
has the wrong version number

This is likely a release script problem, maybe I should just check all that in rather than keep having to find them every time I upgrade desktops....

 

I believe I also saw some older patches from Mike Frysinger but he is
in a better position to say whether they still require an ack:

https://lists.gnu.org/archive/html/nano-devel/2011-11/msg00008.html

r4558

https://lists.gnu.org/archive/html/nano-devel/2011-11/msg00010.html

UTR but I assume certain versions of gcc would complain about this type of thing.  r4559

 

Other remaining patches without an ack:

https://savannah.gnu.org/patch/?7665

Hmm and looks like a few others, but wow this one was pretty blatantly wrong.  r4560.

 Thank you for all your efforts here Eitan and Mike!