nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] clean up autoconf with/enable macros


From: Kamil Dudka
Subject: Re: [Nano-devel] [PATCH] clean up autoconf with/enable macros
Date: Mon, 24 Mar 2014 23:01:29 +0100
User-agent: KMail/4.11.5 (Linux/3.12.13-gentoo; KDE/4.11.5; x86_64; ; )

On Sunday, March 23, 2014 18:03:12 Mike Frysinger wrote:
> This cleans up most, but not all, of the --with/--enable flags:
>  - Use AS_HELP_STRING instead of writing the text ourselves
>  - Use the normal enable_xxx var AC_ARG_ENABLE creates for us
>  - Delete duplicate checks in a few places (due to previous cleanup)
>  - Unwrap some macros/var assignments
>  - Delete trailing whitespace
>  - Delete old --enable-all flag
>  - Fix quoting on a lot of vars that come from the user
>  - Use AC_MSG_* helpers instead of raw `echo`
> ---
>  configure.ac | 193
> ++++++++++++++++++++++++++--------------------------------- 1 file changed,
> 84 insertions(+), 109 deletions(-)

Looks good to me.

Kamil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]