nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] browser: fix handling of large files


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] browser: fix handling of large files
Date: Sat, 18 Jul 2015 12:42:33 +0200

On Thu, Jul 16, 2015, at 04:00, Mike Frysinger wrote:
> On 15 Jul 2015 20:45, Benno Schulenberg wrote:
> > On Wed, Jul 15, 2015, at 12:31, Mike Frysinger wrote:
> > > +     if (modifier != 'G' || result < (1 << 10))
> > > +         sprintf(foo, "%4ju %cB", (intmax_t)result, modifier);
> > 
> > The "modifier != 'G'" isn't needed, I think;  "if (result < (1 << 10))"
> > should be enough, no?
> 
> it might be.  i didn't want to think too hard about the bit shifts and the 
> different cases :).

The trimmed patch went into SVN, r5303.

Thanks.

Benno

-- 
http://www.fastmail.com - Access your email from home and the web




reply via email to

[Prev in Thread] Current Thread [Next in Thread]