|
From: | Rishabh Dave |
Subject: | Re: [Nano-devel] Patch for bug #44950 |
Date: | Wed, 6 Jan 2016 01:07:48 +0530 |
But... determine() returns one of two values, either -1 or 0
-- why not make it a bool? Also, you assign the result of
determine() to m, but never use this variable again, so...
better get rid of it.
More importantly, your patch isn't a unified diff -- it is hard
to read and impossible to apply. Please use 'diff -ur'.
And finally, when running './nano foo/bar/baz', with your patch
nano would say that dir 'foo/bar' does not exist, whereas I would
expect it to say that dir 'foo' does not exist. I admit, it is
harder to make, but the message would be nicer, more natural.
find-nonexistent-dir-basic.patch
Description: Text Data
find-nonexistent-dir-extended.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |