nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] supporting enhanced regexes on OS X [patch]


From: Mike Frysinger
Subject: Re: [Nano-devel] supporting enhanced regexes on OS X [patch]
Date: Mon, 14 Mar 2016 10:36:41 -0400

On 14 Mar 2016 12:00, Benno Schulenberg wrote:
> --- nano/configure.ac (revision 5734)
> +++ nano/configure.ac (revision )
> @@ -572,6 +572,25 @@
>      fi
>  fi
>  
> +AC_MSG_CHECKING([for REG_ENHANCED flag support])
> +nano_reg_extended="REG_EXTENDED"
> +AC_TRY_RUN([

AC_TRY_RUN should pretty much never be used.  this code snippet is a
great example of that being the case too -- all it's doing is looking
for a define in a header.

> +#include <regex.h>
> +int main(void)
> +{
> +#ifdef REG_ENHANCED
> +    return 0;
> +#else
> +    return 1;
> +#endif
> +}],
> +    AC_MSG_RESULT(yes)
> +    nano_reg_extended="REG_EXTENDED | REG_ENHANCED",
> +    AC_MSG_RESULT(no),
> +    AC_MSG_WARN([*** Can't check for REG_ENHANCED flag support when 
> cross-compiling])
> +)

this should be using AC_CACHE_CHECK & AC_PREPROC_IFELSE instead
-mike

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]