[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] browser: merging opendir() in to one
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] browser: merging opendir() in to one |
Date: |
Wed, 25 May 2016 12:25:29 +0200 |
On Tue, May 24, 2016, at 15:10, Rishabh Dave wrote:
> Okay, I removed the cause for momentary display of browser menu (but
> it is ineffective as we already return NULL when path is NULL;
But it is effective when the directory cannot be opend for some reason.
> I added comment in last minute and that is what 2nd patch is about. I
> feel some reader in future would appreciate it if he wouldn't have to
> look out for why path isn't checked before use,
Yeah, actually that is good, but I haven't added it. See further down.
> (Should I avoid
> sending two signed to patches?
Yes. In this case you should have done:
git add src/browser.c
git commit --amend
Deleting lines is easy; and I will edit the patch anyway.
> I did that to keep second optional.)
But the commit message of the second patch is entirely wrong;
it should describe the change of the patch ("add a comment"),
not the change of the previous patch.
Buh... Your first patch doesn't actually move closedir()... :|
I've amended that and pushed the change. And then made an
additional change. And then... found a bug (not caused by
your patch -- it is an old bug):
https://savannah.gnu.org/bugs/?48007
Before taking a second step, see if you can find the cause of
that one.
Benno
--
http://www.fastmail.com - Access your email from home and the web
- [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/14
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/15
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/18
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/19
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/21
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/21
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/22
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/22
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/24
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one,
Benno Schulenberg <=