Re: [Nano-devel] segmentation fault when trying to browse to an inaccessible directory

[Rishabh Dave]

On Sun, Jun 5, 2016 at 1:59 PM, Benno Schulenberg
<address@hidden> wrote:
>
> What else can go wrong?
>
Okay... found two things -

First, accessing directory noaccess using M-T option ("Go To
Directory"-prompt) leads to segfault (since we don't set newpath). I
chose removing opendir from there because otherwise it was adding more
redundancies. Code is in attached patch -
"no1-replace-new_path-by-newpath-remove-opendir-there.patch"

Second, accessing a directory with no read permission lead to jump of
selection to "..". Rearranging code took care of it. Code is in
attached patch -
"no2-keep-selection-when-file-has-no-read-permit.patch"

There is a third patch, attached, that adds a comment. After writing
the comment, I realized it should be avoided to reopen cwd after
selected directory has no access due to redundancy. Apart from
redundant reopening, it also provides an unexpected refresh to the
user (which would lead to surprise on perpetual addition/deletion of
file/dir). So... that is not, strictly speaking, correct, right? I
have attached patch just in case we don't want that. It is
"no4-dont-refresh-unnecessarily.patch".

no1-replace-new_path-by-newpath-remove-opendir-there.patch
Description: Text Data

no2-keep-selection-when-file-has-no-read-permit.patch
Description: Text Data

no3-add-comment.patch
Description: Text Data

no4-dont-refresh-unnecessarily.patch
Description: Text Data