Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt

[Benno Schulenberg]

On Fri, Jun 24, 2016, at 19:31, Rishabh Dave wrote:
> On Fri, Jun 24, 2016 at 5:49 PM, Benno Schulenberg
> <address@hidden> wrote:
> > Then type: ^R ^T M-G /home <Enter>
> >
> > Ignore the error message and type: ^L
> >
> > [ Cannot open directory: File name too long ]Aborted
> 
> Whoa! May I ask how did you catch this bug? It's so... minute.

Well, I saw that newpath was being freed without being set
to null, and then it continued in the central loop, where
newpath is /expected/ to be null.  So... how to get into
that situation?  Use --operatingdir, try to go outside of it,
so that the error message triggers and newpath is nonnull,
and then... how to get to read_directory_contents without
influencing newpath again?  Easy: Refresh.

> Patch is attached. However, last time while working I lost the branch.
> So, I made all arrangements again. Hopefully, it won't add to trouble
> on your side.  :)

It's okay, I knew what the fix was: it was already applied
locally.  :)

If you are content with the attached version, then please
send it back with a Signed-off.

Benno

-- 
http://www.fastmail.com - A no graphics, no pop-ups email service

0001-browser-don-t-seem-to-enter-a-directory-when-it-is-i.patch
Description: Text Data