nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open


From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt
Date: Sat, 25 Jun 2016 21:43:16 +0530

On Fri, Jun 24, 2016 at 11:23 PM, Benno Schulenberg
<address@hidden> wrote:
> On Fri, Jun 24, 2016, at 19:31, Rishabh Dave wrote:
>> Whoa! May I ask how did you catch this bug? It's so... minute.
>
> Well, I saw that newpath was being freed without being set
> to null, and then it continued in the central loop, where
> newpath is /expected/ to be null.  So... how to get into
> that situation?  Use --operatingdir, try to go outside of it,
> so that the error message triggers and newpath is nonnull,
> and then... how to get to read_directory_contents without
> influencing newpath again?  Easy: Refresh.

Oh.. that was elaborate but you did it... smoothly.

> If you are content with the attached version, then please
> send it back with a Signed-off.

Signed-off patch is attached and I tried to cover every aspect of
patch in message body (or I was only suppose to sign-off?).

However, thanks for waiting.  :)

Attachment: 0001-browser-don-t-appear-to-enter-a-directory-when-it-is.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]