nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] "unbind M-Space all" in rcfile changes behaviou


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] "unbind M-Space all" in rcfile changes behaviour of Ctrl-Left
Date: Tue, 11 Oct 2016 10:18:14 +0200

On Mon, Oct 10, 2016, at 19:02, Rishabh Dave wrote:
> When M-Space and ^Space are unbound, Ctrl+Left/Right at prompt doesn't
> work irrespectively. It is a different (but relevant) bug:
> Ctrl+Left/Right at prompt doesn't work when M-/^Space are unbound.
> 
> Please take look at the attached patch that fixes both the bugs.

@@ -494,11 +494,25 @@ int parse_kbinput(WINDOW *win)
[...]
+    if (retval == controlleft) {
+       if (currmenu == MMAIN)
+           do_prev_word_void();

The routine parses the input, which means that it shouldn't /do/
anything there, it shouldn't execute any functions.

Besides, the following is majorly ugly:

+       else if (currmenu == MWHEREIS || currmenu == MWRITEFILE ||
+                       currmenu == MREPLACE || currmenu == MREPLACEWITH ||
+                       currmenu == MINSERTFILE || currmenu == MYESNO ||
+                       currmenu == MGOTOLINE)
+           do_statusbar_prev_word();

In summary: an unacceptable solution.

You have been very close to a good solution when you made
modifications to assign_keyinfo().

Benno

-- 
http://www.fastmail.com - Same, same, but different...




reply via email to

[Prev in Thread] Current Thread [Next in Thread]